Repository navigation
[iOS] Sync drifted internal fixes for the status bar stub and scroll content view - #60078
Merged
Merged
Conversation
huntie
approved these changes
Nov 17, 2026
Visual regressionNo visual differences at android: no capture |
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D132564249. |
vzaidman
approved these changes
Nov 17, 2026
…content view Summary: Brings two internal fixes to GitHub that ShipIt did not export, resolving part of the DiffTrain sync drift on `main`: - Add `getVerticalBarEdge` to the unsupported-platform `RCTStatusBarManager` stub, returning `nil`, so it conforms to the native module spec on tvOS after react#59237. - Declare `RCTScrollContentViewCls` with `RCT_EXTERN` in `RCTScrollContentViewComponentView.h`, matching its component registration linkage (part of the internal import of react#59836). Changelog: [Internal] Test Plan: Both changes are already landed and built internally (tvOS, iOS and macOS). The resulting files match the internal copies.
cipolleschi
force-pushed
the
fix-shipit-drift-T298179666
branch
from
November 17, 2026 16:13
1072b44 to
7e87d46
Compare
cipolleschi
enabled auto-merge (squash)
November 17, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Brings two small iOS fixes that landed internally but were not exported to GitHub, so
mainmatches the internal repository again:getVerticalBarEdgeto the unsupported-platformRCTStatusBarManagerstub (PlatformStubs/RCTStatusBarManager.mm), returningnil, so the stub conforms to the native module spec on tvOS after Add StatusBar.getVerticalBarEdgeIOS and useVerticalBarEdgeIOS for iPhone Duo #59237.RCTScrollContentViewClswithRCT_EXTERNinRCTScrollContentViewComponentView.h, matching its component registration linkage (follow-up to [ScrollView][iOS] Fix auto inset behaviour to use max of safe area inset/container padding #59836).Changelog:
[Internal]
Test Plan:
node_modules/.bin/clang-format --dry-run --Werroron both files: no issues.